Open
Conversation
Member
|
Follow-up iteration for issue_mnt9nu7f_yh77wx / run atomic-js-cloudbase-cli-log-query-by-request-id/2026-04-11T00-48-39-nszg86:
Validation:
The local AI Coding Eval Report API is currently unavailable on 127.0.0.1:5174 in this environment, so I could not run a fresh post-PR evaluation yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated fix attempt
Fixes #514
Source issue: #514
Summary
Summary
Files changed:
mcp/src/tools/logs.ts— Added a directsearchClsLogMCP tool alias alongside the existingqueryLogstool:handleSearchClsLog()functionqueryLogs(action="searchLogs")now delegates tohandleSearchClsLoginstead of duplicating the logicsearchClsLogtool that callshandleSearchClsLogdirectly, withqueryStringas a required parameter (noactionparam needed)queryLogsdescription to note thataction=searchLogsis equivalent to thesearchClsLogtool, following the existing pattern inenv.tsfor legacy tool name documentationmcp/src/tools/logs.test.ts— Added two test cases for the new alias:searchClsLog tool should be registered and search cls logs— verifies tool registration, metadata, and that the handler calls the Manager SDK correctlysearchClsLog should error when queryString is missing— verifies the required-parameter validationDesign rationale: The
searchClsLogtool exposes the canonical CloudBase Manager SDK method name as a direct MCP tool entry, so models/evaluators that already know thesearchClsLogconcept can discover and use it without translating throughqueryLogs(action="searchLogs"). Both tools share the same underlying handler, avoiding code duplication.